New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flume: Add flume.list_notifications service #100621
Conversation
Hey there @ChrisMandich, @bdraco, @jeeftor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tronikos 👍
../Frenck
Can this please be merged before Wednesday to make it in the next release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tronikos 👍
@tronikos Please open a docs PR, where you document the new service and link the PR in the description |
|
Proposed change
Add a service to return all user notifications. Goal is to alert in Home Assistant for any usage alert and not just the low flow leak or high flow for which we already have binary sensors. Using service response, automations can use the title and message in the response as is to call notify services in Home Assistant.
To avoid hitting the API quota, the service returns previously fetched notifications that are refreshed every 5 minutes.
This is an alternative to #100583
Example:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: