Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flume: Add flume.list_notifications service #100621

Merged
merged 6 commits into from Oct 25, 2023

Conversation

tronikos
Copy link
Contributor

@tronikos tronikos commented Sep 19, 2023

Proposed change

Add a service to return all user notifications. Goal is to alert in Home Assistant for any usage alert and not just the low flow leak or high flow for which we already have binary sensors. Using service response, automations can use the title and message in the response as is to call notify services in Home Assistant.

To avoid hitting the API quota, the service returns previously fetched notifications that are refreshed every 5 minutes.

This is an alternative to #100583

Example:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @ChrisMandich, @bdraco, @jeeftor, mind taking a look at this pull request as it has been labeled with an integration (flume) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of flume can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign flume Removes the current integration label and assignees on the pull request, add the integration domain after the command.

homeassistant/components/flume/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/flume/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/flume/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/flume/__init__.py Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 6, 2023 15:22
@home-assistant
Copy link

home-assistant bot commented Oct 6, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@tronikos tronikos marked this pull request as ready for review October 6, 2023 18:32
@home-assistant home-assistant bot requested a review from frenck October 6, 2023 18:32
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tronikos 👍

../Frenck

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 6, 2023
@tronikos
Copy link
Contributor Author

Can this please be merged before Wednesday to make it in the next release?

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tronikos 👍

@edenhaus edenhaus merged commit 89e2f06 into home-assistant:dev Oct 25, 2023
18 of 19 checks passed
@edenhaus
Copy link
Contributor

edenhaus commented Oct 25, 2023

@tronikos Please open a docs PR, where you document the new service and link the PR in the description

@tronikos tronikos deleted the flume_service branch October 25, 2023 17:17
@tronikos tronikos changed the title Flume: Add flume.notifications service Flume: Add flume.list_notifications service Oct 25, 2023
@tronikos
Copy link
Contributor Author

@tronikos Please open a docs PR, where you document the new service and link the PR in the description

home-assistant/home-assistant.io#29543

@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: flume new-feature Quality Scale: No score smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants