Add device class to denonavr

[DanielWeeber]

Proposed change

adding device_class TV to denonavr component
fixes partially #94917

Type of change

• Dependency upgrade
• [ x] Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue:
• This PR is related to issue: Denon Receivers HomeKit Switches instead of Receiver #94917
• Link to documentation pull request:

Checklist

• [ x] The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the [development checklist][dev-checklist]
• I have followed the [perfect PR recommendations][perfect-pr]
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

• The [manifest file][manifest-docs] has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

[home-assistant]

Hi @DanielWeeber

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Hey there @ol-iver, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (denonavr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of denonavr can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign denonavr Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[starkillerOG]

Well, the denonavr integration gives you a audio video receiver (AVR), it is not a TV.....
I would argue that it more closely represents a speaker than a TV.

[DanielWeeber]

@starkillerOG @joostlek RECEIVER and out of constructor done

[joostlek]

Oh and please click ready for review :)

[bdraco]

This won't resolve the linked issue (which probably should be closed anyways since its a feature request, and HA doesn't want issues for feature requests) because the HomeKit implementation doesn't currently support receivers.

It needs to be added in these two places

core/homeassistant/components/homekit/accessories.py

Line 186 in d30a5f4

if device_class == MediaPlayerDeviceClass.TV:

core/homeassistant/components/homekit/util.py

Line 617 in 5b422da

and state.attributes.get(ATTR_DEVICE_CLASS) == MediaPlayerDeviceClass.TV

And than subclassed so its the same as TV but sets the category to AUDIO_RECEIVER = 34

HomeKit implementations generally map receivers as TVs so you'll also need to do a PR to the homekit integration to map receivers to be treated the same as TVs if you want to address what was requested in #94917

[DanielWeeber]

Yeah, but the TV integration is way better than it being a Switch. If the homekit integration will support Receivers in the future it will just work.

[bdraco]

Yeah, but the TV integration is way better than it being a Switch. If the homekit integration will support Receivers in the future it will just work.

I agree, I'm only saying it doesn't solve the problem reported in the issue and more work is needed to achieve that with another PR.

[bdraco]

I changed fixes #94917 to fixes partially #94917 since fixes is a closing keyword and will auto close #94917 on merge.

[bdraco]

Thanks @DanielWeeber

[bdraco]

#100717