Improve Plugwise climate #100730
Improve Plugwise climate #100730
Conversation
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: plugwise
small-pr
|
Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Co-authored-by: J. Nick Koston <nick@koston.org>
|
@bdraco thanks for reviewing! |
| @@ -67,17 +67,17 @@ def __init__( | |||
| self._attr_preset_modes = presets | |||
|
|
|||
| # Determine hvac modes and current hvac mode | |||
| self._attr_hvac_modes = [HVACMode.HEAT] | |||
| self._attr_hvac_modes = [HVACMode.OFF, HVACMode.HEAT] | |||
There was a problem hiding this comment.
Plugwise doesn't support "off" natively?
There was a problem hiding this comment.
For an Adam with and OpenTherm device, Plugwise does. The regulation_mode off could be used for this:
We could add the mode = off option for configurations that provide this option. We would need to investigate a bit more how to implement the setting to off-mode.
An Anna connected to an OpenTherm device does not provide such an option.
For other Anna-configurations, with city-heating via a valve/valves, OnOff-devices, we would need to investigate.
There was a problem hiding this comment.
Realizing this will be complex, a Select needs to be set to off and later back to its previous state.
This previous state has to be saved in HA and survive a HA restart. This previous state cannot be provided by the Plugwise-backend because a restart will also erase the previous state in the backend.
There was a problem hiding this comment.
As an alternative, the Google Assistant integration could add the HVACMode.OFF when a thermostat does not have this mode. This would correct the operation in Google Home for all thermostats without the HVACMode.OFF.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Replaced by #103360 |
Proposed change
Two improvements:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: