Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'last_reset' for 'total' state_class template sensor #100806

Merged
merged 7 commits into from Jan 25, 2024

Conversation

RoboMagus
Copy link
Contributor

@RoboMagus RoboMagus commented Sep 24, 2023

Proposed change

Users are able to configure the state_class to be total for template sensors, but currently do not have the option to add a last_reset to this configuration. For e.g. sensors that do have a periodic reset, but may not be monotonically increasing this is a missing feature when properly trying to track statistics.

This PR aims to fix that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @PhracturedBlue, @tetienne, @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of template can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign template Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@RoboMagus RoboMagus changed the title Add template sensor Add 'last_reset' for 'total' state_class template sensor Sep 24, 2023
@RoboMagus RoboMagus force-pushed the last_reset_template_sensor branch 3 times, most recently from 5730a91 to 2c33dc4 Compare October 1, 2023 09:44
@RoboMagus RoboMagus marked this pull request as ready for review October 1, 2023 14:49
@RoboMagus RoboMagus requested a review from a team as a code owner October 1, 2023 14:49
Copy link

github-actions bot commented Dec 9, 2023

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Dec 9, 2023
@RoboMagus
Copy link
Contributor Author

Would still like to see this integrated :)

@RoboMagus
Copy link
Contributor Author

@PhracturedBlue, @tetienne, Mind taking a look?
The documentation PR was approved already a couple of months ago.

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @RoboMagus 👍

@emontnemery emontnemery reopened this Jan 23, 2024
@emontnemery
Copy link
Contributor

(Close open to force CI to re-run)

@emontnemery emontnemery merged commit c54b65f into home-assistant:dev Jan 25, 2024
97 of 99 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants