Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monthly forecast sensor to RymPro #101012

Merged
merged 5 commits into from Feb 15, 2024
Merged

Add monthly forecast sensor to RymPro #101012

merged 5 commits into from Feb 15, 2024

Conversation

OnFreund
Copy link
Contributor

Proposed change

Add a monthly forecast sensor to the RymPro integration. It was initially part of #87370, but the other sensors can be replaced by utility meters, and adding just the forecast significantly simplifies everything.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @elad-bar, @maorcc, mind taking a look at this pull request as it has been labeled with an integration (rympro) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rympro can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign rympro Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@OnFreund OnFreund mentioned this pull request Sep 27, 2023
Closed
19 tasks
epenet
epenet previously requested changes Sep 28, 2023
View reviewed changes
homeassistant/components/rympro/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/rympro/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 28, 2023 06:01
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@OnFreund OnFreund marked this pull request as ready for review September 28, 2023 06:24
@epenet epenet dismissed their stale review September 28, 2023 06:57

Comments have been adressed

frenck
frenck previously requested changes Oct 7, 2023
View reviewed changes
homeassistant/components/rympro/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 7, 2023 12:03
@OnFreund OnFreund marked this pull request as ready for review October 21, 2023 08:38
@home-assistant home-assistant bot requested a review from frenck October 21, 2023 08:38
@OnFreund
Copy link
Contributor Author

@frenck @epenet are there any additional comments?

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 27, 2023
edenhaus
edenhaus previously requested changes Nov 29, 2023
View reviewed changes
homeassistant/components/rympro/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/rympro/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/rympro/sensor.py Show resolved Hide resolved
homeassistant/components/rympro/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/rympro/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 29, 2023 13:50
@edenhaus edenhaus self-assigned this Nov 29, 2023
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Nov 30, 2023
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Jan 29, 2024
@OnFreund
Copy link
Contributor Author

Not stale

@github-actions github-actions bot removed the stale label Jan 29, 2024
@emontnemery
Copy link
Contributor

@OnFreund Please don't forget to click the ready for review button if you want the PR to be reviewed 👍

OnFreund and others added 4 commits February 14, 2024 20:22
@OnFreund
Add monthly forecast
8247048
@OnFreund @epenet
Apply suggestions from code review
c4d108f 
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@OnFreund
Remove state class and add precision
e85a0e4
@OnFreund @edenhaus
Apply suggestions from code review
e4df571 
Co-authored-by: Robert Resch <robert@resch.dev>
@OnFreund OnFreund marked this pull request as ready for review February 14, 2024 18:44
emontnemery
emontnemery approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @OnFreund 👍

@emontnemery emontnemery dismissed stale reviews from edenhaus and frenck February 15, 2024 11:33

stale

@emontnemery emontnemery merged commit d4be663 into home-assistant:dev Feb 15, 2024
23 checks passed
@OnFreund OnFreund deleted the rympro_forecast2 branch February 15, 2024 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emontnemery emontnemery emontnemery approved these changes

@epenet epenet Awaiting requested review from epenet

@frenck frenck Awaiting requested review from frenck

@edenhaus edenhaus Awaiting requested review from edenhaus

Assignees

@edenhaus edenhaus

Labels
by-code-owner cla-signed integration: rympro new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@OnFreund @emontnemery @frenck @epenet @edenhaus