Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dataclass for stream segment Part #101128

Merged
merged 2 commits into from Sep 29, 2023
Merged

Use dataclass for stream segment Part #101128

merged 2 commits into from Sep 29, 2023

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Sep 29, 2023

Proposed change

SSIA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @hunterjm, @uvjustin, @allenporter, mind taking a look at this pull request as it has been labeled with an integration (stream) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of stream can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign stream Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@uvjustin uvjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since our minimum supported python version is 3.10, we can use slots=True to keep it almost the same as the attr.ib implementation.
Are you going to make a PR for Segment as well?

@jbouwh
Copy link
Contributor Author

jbouwh commented Sep 29, 2023

Since our minimum supported python version is 3.10, we can use slots=True to keep it almost the same as the attr.ib implementation. Are you going to make a PR for Segment as well?

Not sure it is possible to use dataclass for Segment

@uvjustin
Copy link
Contributor

Not sure it is possible to use dataclass for Segment

No problem, I was just wondering. I can have a look at doing it tomorrow.

@uvjustin uvjustin changed the title Use data class for stream segement Part Use data class for stream segment Part Sep 29, 2023
@uvjustin uvjustin changed the title Use data class for stream segment Part Use dataclass for stream segment Part Sep 29, 2023
@jbouwh
Copy link
Contributor Author

jbouwh commented Sep 29, 2023

Not sure it is possible to use dataclass for Segment

No problem, I was just wondering. I can have a look at doing it tomorrow.

Right, well I suggest keeping the scope for this PR to Segment.

Copy link
Contributor

@uvjustin uvjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbouwh
Copy link
Contributor Author

jbouwh commented Sep 29, 2023

Thnx @bdraco and @uvjustin !

@jbouwh jbouwh merged commit 26ba10f into dev Sep 29, 2023
34 checks passed
@jbouwh jbouwh deleted the stream-dataclass branch September 29, 2023 19:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants