New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the MarkdownV2 parser with the Telegram bot #101139
Using the MarkdownV2 parser with the Telegram bot #101139
Conversation
It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Added the use of the MarkdownV2 parser type when sending Telegram bot messages.
The documentation uses markdownv2.
57f1be5
to
78676a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the docs capitalize it as MarkdownV2
but in practice it seems case-insensitive: https://github.com/tdlib/telegram-bot-api/blob/5d88023dd1e65b7d0926a71aea4487d6cac3bf13/telegram-bot-api/Client.cpp#L7254
So, LGTM.
The documentation uses lowercase letters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @YuriiMaiboroda 👍
../Frenck
Breaking change
In telegram bot services, the
markdown2
item inparse_mode
option has been renamed tomarkdownv2
, according to the documentation.Proposed change
Added the use of the MarkdownV2 parser type when sending Telegram bot messages.
In telegram bot services, the
markdown2
item inparse_mode
option has been renamed tomarkdownv2
, according to the documentation. This should not break any automation, as themarkdown2
option was previously unrecognized and continues to be unrecognized.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: