Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat strings starting with https but not htt as soundtouch media URLs #101183

Merged
merged 1 commit into from Oct 1, 2023

Conversation

scop
Copy link
Member

@scop scop commented Oct 1, 2023

Proposed change

This caught my attention while looking into something else. I don't actually know anything about soundtouch or if we'd actually like to match htt:// here, but I'm assuming not, and that the intention was to match https:// instead. If that assumption is incorrect, I suggest adding a comment or a test case to clarify.

While at it, match case insensitively, as URL schemes are case insensitive.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Oct 1, 2023

Hey there @kroimon, mind taking a look at this pull request as it has been labeled with an integration (soundtouch) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of soundtouch can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign soundtouch Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@kroimon kroimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SoundTouch products unfortunately can not play https media, but the case insensitivity is a good catch.

`htt://` sounds like a typo. While at it, match case insensitively.
@scop scop force-pushed the scop-soundtouch-url-regexp branch from fb2fe66 to 896cc83 Compare October 1, 2023 13:12
@scop
Copy link
Member Author

scop commented Oct 1, 2023

Ok, removed that modification, still with the assumption that support for htt:// (no p) was kind of a typo.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @scop 👍

../Frenck

@frenck frenck merged commit 31ea00f into dev Oct 1, 2023
21 checks passed
@frenck frenck deleted the scop-soundtouch-url-regexp branch October 1, 2023 14:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants