Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue bytes vs str related warnings from tests #101186

Merged
merged 1 commit into from Nov 27, 2023
Merged

Conversation

scop
Copy link
Member

@scop scop commented Oct 1, 2023

Proposed change

To be applied on top of #101185

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@scop scop marked this pull request as draft October 1, 2023 07:24
@scop scop mentioned this pull request Oct 1, 2023
20 tasks
@frenck
Copy link
Member

frenck commented Oct 1, 2023

What would be the motivation for this PR?

../Frenck

@scop
Copy link
Member Author

scop commented Oct 3, 2023

Per the python3 man page:

-b     Issue warnings about str(bytes_instance), str(bytearray_instance) and comparing bytes/bytearray with str.

...so catching likely bugs. -bb would be even better, but it triggers on problems in dependencies, causing failures because the errors cannot be individually ignored.

Base automatically changed from scop-python3-m-pytest to dev October 6, 2023 11:22
@frenck
Copy link
Member

frenck commented Oct 7, 2023

@scop There is a merge conflict on this PR right now. Could you take a look?

@scop
Copy link
Member Author

scop commented Nov 27, 2023

Resolved & rebased, sorry about the delay.

@scop scop marked this pull request as ready for review November 27, 2023 17:27
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @scop 👍

../Frenck

@frenck frenck merged commit fd5cda4 into dev Nov 27, 2023
53 checks passed
@frenck frenck deleted the scop-python3-b-pytest branch November 27, 2023 20:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants