Allow setting hvac mode through set_temperature climate method in Gree integration #101196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
Hacktoberfest
has-tests
integration: gree
new-feature
small-pr
|
Hey there @cmroche, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
MislavMandaric
commented
Oct 1, 2023
| @@ -407,6 +414,58 @@ async def test_send_target_temperature( | |||
| state.attributes.get(ATTR_CURRENT_TEMPERATURE) | |||
| == fake_device.current_temperature | |||
| ) | |||
| assert state.state == HVAC_MODES.get(fake_device.mode) | |||
There was a problem hiding this comment.
This adds a check that hvac mode didn't change in existing test for setting the temperature, while the new test checks that both temperature and hvac mode got changed.
gjohansson-ST
requested changes
Oct 1, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
gjohansson-ST
requested changes
Oct 3, 2023
gjohansson-ST
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Support for handling optional
hvac_modeparameter when callingclimate.set_temperatureon Gree integration, as per the docs.Previously this parameter was ignored.
Type of change
Checklist
black --fast homeassistant tests)To help with the load of incoming pull requests: