Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyyardian to 1.1.1 #101363

Merged
merged 2 commits into from Oct 5, 2023
Merged

Bump pyyardian to 1.1.1 #101363

merged 2 commits into from Oct 5, 2023

Conversation

h3l1o5
Copy link
Contributor

@h3l1o5 h3l1o5 commented Oct 4, 2023

Breaking change

Proposed change

Bump pyyardian from 1.1.0 to 1.1.1: h3l1o5/pyyardian@1.1.0...1.1.1
Support 6 zones YardianPro (model: PRO1906)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@h3l1o5
Copy link
Contributor Author

h3l1o5 commented Oct 4, 2023

umm.. I'm not really sure why this PR contains so many commits. I've already done the sync fork to my own repo.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your branch on latest dev branch and remove the unrelated commits.

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

@home-assistant
Copy link

home-assistant bot commented Oct 4, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 4, 2023 07:26
@joostlek joostlek changed the title Update Yardian's dependency pyyardian from 1.1.0 to 1.1.1 Bump pyyardian to 1.1.1 Oct 4, 2023
@h3l1o5 h3l1o5 force-pushed the yardian branch 2 times, most recently from bfd3a54 to 386dd15 Compare October 5, 2023 01:51
@h3l1o5 h3l1o5 marked this pull request as ready for review October 5, 2023 02:33
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 0c8e1a6 into home-assistant:dev Oct 5, 2023
34 checks passed
@frenck frenck added this to the 2023.10.1 milestone Oct 5, 2023
grace43 pushed a commit to grace43/core that referenced this pull request Oct 5, 2023
* Update Yardian Dependency

* test requirements
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yardian Integration crashes during config
3 participants