Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Hue integration to use Entity descriptions and translatable entity names #101413

Merged
merged 10 commits into from Oct 9, 2023

Conversation

marcelveldt
Copy link
Member

Proposed change

The Hue integration was not yet fully leveraging the latest additions such as translation_keys and entity descriptions.
Consider this a housekeeping PR to make the (v2) Hue integration code up-to-date again with the latest HA changes, especially using the new naming conventions based on device classes and translation_key.

Now that the device/entity names are now actually based on the device itself, this actually brings a few improvements where the entity name is updated instantly when the device name changes and new zones and groups immediately add a new grouped light.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Oct 4, 2023

Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration (hue) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hue can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hue Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@marcelveldt marcelveldt changed the title Adjust Hue integrations to use Entity descriptions and translatable entity names Adjust Hue integration to use Entity descriptions and translatable entity names Oct 4, 2023
homeassistant/components/hue/strings.json Outdated Show resolved Hide resolved
homeassistant/components/hue/strings.json Outdated Show resolved Hide resolved
homeassistant/components/hue/scene.py Show resolved Hide resolved
homeassistant/components/hue/event.py Show resolved Hide resolved
homeassistant/components/hue/switch.py Show resolved Hide resolved
homeassistant/components/hue/strings.json Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Oct 4, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 4, 2023 18:28
@marcelveldt marcelveldt marked this pull request as ready for review October 5, 2023 11:51
@home-assistant home-assistant bot requested a review from joostlek October 5, 2023 11:51
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joost is right in his comment, and it should be addressed.

@home-assistant home-assistant bot marked this pull request as draft October 6, 2023 17:52
@marcelveldt
Copy link
Member Author

Yep, I know, some more leftover mess, sorry. I'll fix it as soon as I'm back on my machine

@marcelveldt marcelveldt marked this pull request as ready for review October 9, 2023 11:30
@home-assistant home-assistant bot requested a review from frenck October 9, 2023 11:30
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marcelveldt 👍

../Frenck

@frenck frenck dismissed joostlek’s stale review October 9, 2023 12:14

Comment addressed

@frenck frenck merged commit 6393171 into dev Oct 9, 2023
21 checks passed
@frenck frenck deleted the hue-entity-descriptions-names branch October 9, 2023 12:14
grace43 pushed a commit to grace43/core that referenced this pull request Oct 9, 2023
…tity names (home-assistant#101413)

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
grace43 pushed a commit to grace43/core that referenced this pull request Oct 9, 2023
…tity names (home-assistant#101413)

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants