New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Hue integration to use Entity descriptions and translatable entity names #101413
Conversation
Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
3f27750
to
627f0a5
Compare
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
f7d0c6d
to
a271d38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Joost is right in his comment, and it should be addressed.
Yep, I know, some more leftover mess, sorry. I'll fix it as soon as I'm back on my machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @marcelveldt 👍
../Frenck
…tity names (home-assistant#101413) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
…tity names (home-assistant#101413) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Proposed change
The Hue integration was not yet fully leveraging the latest additions such as translation_keys and entity descriptions.
Consider this a housekeeping PR to make the (v2) Hue integration code up-to-date again with the latest HA changes, especially using the new naming conventions based on device classes and translation_key.
Now that the device/entity names are now actually based on the device itself, this actually brings a few improvements where the entity name is updated instantly when the device name changes and new zones and groups immediately add a new grouped light.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: