Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device_class.capitalize() in Point #101440

Merged
merged 5 commits into from Oct 6, 2023
Merged

Conversation

fredrike
Copy link
Contributor

@fredrike fredrike commented Oct 5, 2023

Proposed change

Fixes an issue when setting up binary sensors as the parent class expect the device_class to be set (this defaults to device_name which is the intended behaviour):

self._attr_name = f"{self._name} {device_class.capitalize()}"

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

homeassistant/components/point/binary_sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 5, 2023 08:17
@home-assistant
Copy link

home-assistant bot commented Oct 5, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@edenhaus edenhaus changed the title Fix issue with device_class.capitalize() Fix device_class.capitalize() in Point Oct 5, 2023
@fredrike fredrike requested a review from edenhaus October 5, 2023 09:40
@fredrike fredrike marked this pull request as ready for review October 5, 2023 09:40
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fredrike 👍

@frenck frenck added this to the 2023.10.1 milestone Oct 6, 2023
@frenck frenck dismissed edenhaus’s stale review October 6, 2023 16:23

Comment addressed

@frenck frenck merged commit d654c4b into home-assistant:dev Oct 6, 2023
21 checks passed
frenck pushed a commit that referenced this pull request Oct 6, 2023
@frenck frenck mentioned this pull request Oct 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants