Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to API in airnow option flow tests #101457

Merged
merged 1 commit into from Oct 5, 2023
Merged

Conversation

emontnemery
Copy link
Contributor

Proposed change

Fix call to API in airnow option flow tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Oct 5, 2023

Hey there @asymworks, mind taking a look at this pull request as it has been labeled with an integration (airnow) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airnow can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airnow Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setup_airnow fixture is weird. It uses async_setup_component without any config entry and there's no async_setup or YAML config for this integration.

tests/components/airnow/test_config_flow.py Show resolved Hide resolved
@emontnemery
Copy link
Contributor Author

The setup_airnow fixture is weird. It uses async_setup_component without any config entry and there's no async_setup or YAML config for this integration.

Agreed, but let's fix that in another PR.

@emontnemery emontnemery mentioned this pull request Oct 5, 2023
20 tasks
@MartinHjelmare MartinHjelmare merged commit 2464232 into dev Oct 5, 2023
21 checks passed
@MartinHjelmare MartinHjelmare deleted the airnow_fix_api_call branch October 5, 2023 11:24
grace43 pushed a commit to grace43/core that referenced this pull request Oct 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants