New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase max bind vars based on database version #101464
Conversation
accept value of 4000 instead of 20000 Co-authored-by: J. Nick Koston <nick@koston.org>
reduce test blob for speed up
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little question otherwise seems nice 😌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bdraco 👍
../Frenck
thanks |
Proposed change
For sqlite 3.32+ we can increase the max bind vars to purge / migrate more data in one call. For postgresql and mysql we can always use a larger max bind vars.
This is also a small improvement to startup time as well do a few less queries to find the attributes and states meta ids to record initial states
replaces and closes #96955
related issue #101100
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: