Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging of retrying config entry warning #101483

Merged
merged 3 commits into from Oct 5, 2023
Merged

Remove logging of retrying config entry warning #101483

merged 3 commits into from Oct 5, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Oct 5, 2023

Proposed change

This PR removes warning logs like these:

Config entry 'Samsung Q900 Series (65)' for apple_tv integration not ready yet: Not found at 192.168.1.179, waiting for discovery; Retrying in background

These are nice, but are also already visible in the UI; so a duplicate.
I've left the debug log version in place, which an normal user shouldn't have in their logs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • [] I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck requested a review from a team as a code owner October 5, 2023 17:11
Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I was thinking about it myself, the warning is just annoying since this happens at startup and you end up with too much warnings that you don't really need to do anything about them.

Note that there are two failed tests

@frenck
Copy link
Member Author

frenck commented Oct 5, 2023

Note that there are two failed tests

Shoot! 😢 Sorry about that.

Pushed an update!

../Frenck

@gjohansson-ST
Copy link
Member

FAILED tests/components/yeelight/test_init.py::test_async_setup_retries_with_wrong_device - AssertionError: assert 'Unexpected device found at 192.168.1.239 ....

@frenck frenck merged commit 6853d54 into dev Oct 5, 2023
34 checks passed
@frenck frenck deleted the frenck-2023-1239 branch October 5, 2023 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants