Bump switchbot-api to 1.2.1 #101664
Merged
Bump switchbot-api to 1.2.1 #101664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tchBot-Cloud--Dependency-update
home-assistant
bot
added
cla-signed
dependency
Hacktoberfest
integration: switchbot_cloud
small-pr
SeraphicRav
commented
Oct 8, 2023
| @@ -32,6 +32,18 @@ class SwitchbotCloudData: | |||
| devices: SwitchbotDevices | |||
|
|
|||
|
|
|||
| def prepare_device( | |||
There was a problem hiding this comment.
This is to avoid to create unused coordinators
frenck
added
the
smash
MartinHjelmare
changed the title
|
Please don't touch the branch after approval unless requested. Thanks! |
Oh sorry |
|
@SeraphicRav Did you miss the message by @MartinHjelmare Above? Even after he posted that, you still make changes to the branch? Marking this PR draft. As I don't know when you are ready... 🤷 ../Frenck |
Sorry, I completely missed the message, I will not touch the branch anymore. |
MartinHjelmare
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Bumping switchbot-api version up
Main change is that the dependency sends all devices without filtering.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: