Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slack type error for file upload #101720

Merged
merged 1 commit into from Oct 10, 2023

Conversation

tkdrob
Copy link
Contributor

@tkdrob tkdrob commented Oct 9, 2023

Breaking change

Proposed change

Fix TypeError in Slack integration regression from #93384 where file uploads were failing

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Oct 9, 2023

Hey there @FletcherAU, mind taking a look at this pull request as it has been labeled with an integration (slack) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of slack can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign slack Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@FletcherAU
Copy link
Contributor

My apologies, thanks @tkdrob

@MartinHjelmare MartinHjelmare changed the title Fix Slack integration regression from #93384 Fix Slack type error for file upload Oct 10, 2023
@MartinHjelmare MartinHjelmare added this to the 2023.10.2 milestone Oct 10, 2023
@MartinHjelmare MartinHjelmare merged commit e5d5440 into home-assistant:dev Oct 10, 2023
21 checks passed
@tkdrob tkdrob deleted the slack_regress branch October 10, 2023 10:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to send a local file via notify service
4 participants