-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter OpenUV to allow for automatic updating of the protection window sensor #101737
Conversation
8b2465a
to
aae94ea
Compare
While in draft, jotting some notes about how the update logic will work for the
|
360a6ce
to
8708774
Compare
The most recent release (2023.11) is showing the Protection Window sensor as Unknown following the update. Wondering if this might fix that? Let me know if you want me to raise a full ticket for that. |
@codyc1515 It should. My day job unfortunately made it so I couldn't get this into today's release, but I'll try to wrap it up for the next one. |
370b43d
to
4bfa0e5
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
OpenUV entities are manually updated by calling the
homeassistant.update_entity
service to protect API overruns. Recently, I learned that the protection window API response contains the datetimes at which the protection window begins and ends; this means we no longer need to callhomeassistant.update_entity
on this entity.Therefore, this PR does two things:
No. 2 is technically not a deprecation, as users are still free to update the sensor ad hoc with
homeassistant.update_entity
(I currently don't have plans to remove this capability).Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: