Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust WeatherFlow air density sensor device class and unit #101777

Merged
merged 1 commit into from Oct 15, 2023
Merged

Adjust WeatherFlow air density sensor device class and unit #101777

merged 1 commit into from Oct 15, 2023

Conversation

natekspencer
Copy link
Contributor

Breaking change

Removes the VOC device class from the air density sensor and adjusts the unit to kg/m³

Proposed change

Adjust WeatherFlow air density sensor device class and unit

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @jeeftor, mind taking a look at this pull request as it has been labeled with an integration (weatherflow) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of weatherflow can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign weatherflow Removes the current integration label and assignees on the pull request, add the integration domain after the command.

davet2001
davet2001 reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just had one question.

homeassistant/components/weatherflow/sensor.py
suggested_display_precision=3,
raw_data_conv_fn=lambda raw_data: raw_data.m * 1000000,
suggested_display_precision=5,
raw_data_conv_fn=lambda raw_data: raw_data.magnitude,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the reason for .magnitude here, but probably I am missing something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyweatherflowudp library uses Pint which has a Quantity (value + unit) class. That class has a shortcode property .m which is the same as .magnitude. It's only .magnitude here to match the rest of the sensors in the file.

@davet2001
Copy link
Contributor

Looks good to me but would be good to get confirmation from @jeeftor since this is a breaking change.

@bdraco bdraco merged commit 36fcf19 into home-assistant:dev Oct 15, 2023
21 checks passed
@natekspencer natekspencer deleted the weatherflow-air-density branch October 15, 2023 17:28
@jeeftor
Copy link
Contributor

jeeftor commented Oct 16, 2023

Looks good to me too

@jeeftor
Copy link
Contributor

jeeftor commented Oct 16, 2023

But i was on vacation and then got the corona virus... so I'm most tardy to respond.

@bdraco
Copy link
Member

bdraco commented Oct 16, 2023

But i was on vacation and then got the corona virus... so I'm most tardy to respond.

No worries, considering Nate did the original integration I was confident about merging.

Feel better soon!

allenporter pushed a commit to allenporter/home-assistant-core that referenced this pull request Oct 17, 2023
@natekspencer @allenporter
Adjust WeatherFlow air density sensor device class and unit (home-ass…
2f1b600 
…istant#101777)
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

@davet2001 davet2001 davet2001 approved these changes

Assignees
No one assigned
Labels
breaking-change by-code-owner cla-signed Hacktoberfest integration: weatherflow Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@natekspencer @davet2001 @jeeftor @bdraco