Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy to 1.6.0 #101780

Merged
merged 5 commits into from Oct 11, 2023
Merged

Update mypy to 1.6.0 #101780

merged 5 commits into from Oct 11, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 10, 2023

Proposed change

https://mypy-lang.blogspot.com/2023/10/mypy-16-released.html

  • The type definition for dict.get was updated to better handle dict[str, Any].
    Previously the resulting type of get with a default value would be the type of the default value itself even though it can still be the value type of the dict (i.e. Any). The full workaround would be to use TypedDicts instead but this isn't always practical -> should not be done in this PR. Added type: ignore[no-any-return] instead. See 1214cbf
def f(a: dict[str, Any]) -> str:
    reveal_type(a.get("key", "default_val"))  # Previously 'str' -> Now 'Any'
    return a.get("key", "default_val")  # type: ignore[no-any-return]

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@cdce8p cdce8p marked this pull request as ready for review October 11, 2023 10:57
@cdce8p cdce8p added the smash Indicator this PR is close to finish for merging or closing label Oct 11, 2023
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃徎 for media extractor

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 馃憤

../Frenck

@frenck frenck merged commit 0b2b486 into home-assistant:dev Oct 11, 2023
51 checks passed
@cdce8p cdce8p deleted the update-mypy-1.6.0 branch October 11, 2023 11:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency dependency-bump Hacktoberfest small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants