Avoid polling state machine for available state in HomeKit #101799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we already get state changed events we can avoid polling the state machine each time HomeKit does a sync or a UI is loaded since we already know if the underlying entity is available
home-assistant
bot
added
cla-signed
code-quality
Hacktoberfest
integration: homekit
small-pr
bdraco
commented
Oct 11, 2023
Comment on lines
-421
to
-422
| state = self.hass.states.get(self.entity_id) | ||
| return state is not None and state.state != STATE_UNAVAILABLE |
There was a problem hiding this comment.
The goal is to get rid of the state machine lookup here since we can already remember it since we are tracking it
bdraco
changed the title
|
No changes, just merged in dev to fix conflict on my integration |
20 tasks
joostlek
approved these changes
Oct 14, 2023
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Since we already get state changed events we can avoid polling the state machine each time HomeKit does a sync or a UI is loaded since we already know if the underlying entity is available.
This is already covered by the existing tests.
This also helps cameras as well since we have to hit this path during the camera keep alives.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: