Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up stale ZHA database listener when reconnecting to radio #101850

Merged

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Oct 11, 2023

Proposed change

A stale database listener is left over if the initial radio connection fails and ZHA performs one of its internal retries to try again. This PR incorporates a bumped version of the zigpy package (0.58.0) that includes a fix. This PR also corrects an issue with config entry unload and HA Core shutdown closing the ZHA gateway.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@puddly puddly marked this pull request as draft October 12, 2023 05:40
@frenck frenck modified the milestones: 2023.10.2, 2023.10.3, 2023.10.4 Oct 12, 2023
@puddly puddly marked this pull request as ready for review October 18, 2023 23:13
@frenck frenck merged commit 8a79870 into home-assistant:dev Oct 20, 2023
53 checks passed
@frenck frenck removed this from the 2023.10.4 milestone Oct 20, 2023
@frenck
Copy link
Member

frenck commented Oct 20, 2023

Removed it from the patch milestone, as it has quite a big conflict.

Upcoming Wednesday the beta starts for the next release, so I suggest to just await that.

@puddly
Copy link
Contributor Author

puddly commented Oct 20, 2023

@frenck Is there anything I can do to make it easier to merge?

This PR fixes a problem with ZHA startup that prevents radios from functioning if they require a second connection attempt to get working. If there's another PR that conflicts with this one, perhaps we can drop that one instead?

@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants