Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SMA incorrect device class #101866

Merged
merged 1 commit into from Oct 12, 2023
Merged

Fix SMA incorrect device class #101866

merged 1 commit into from Oct 12, 2023

Conversation

rklomp
Copy link
Contributor

@rklomp rklomp commented Oct 12, 2023

Proposed change

Will remove device_class and state_class from grid_power_factor_excitation SensorEntityDescription
The value of this sensor is a string.

Causes issues since 2023.10
See #101643 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @kellerza, mind taking a look at this pull request as it has been labeled with an integration (sma) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sma can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sma Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@joostlek
Copy link
Member

Can you maybe give examples of what the value can be?

@rklomp
Copy link
Contributor Author

rklomp commented Oct 12, 2023

Can you maybe give examples of what the value can be?

One of the values is 'Overexcited', don't know exactly what other values this could have.

@joostlek
Copy link
Member

Can we maybe figure out what the values can be? In that case we can transform this into an enum device class.

@rklomp
Copy link
Contributor Author

rklomp commented Oct 12, 2023

Can we maybe figure out what the values can be? In that case we can transform this into an enum device class.

There is no documentation from SMA that describes this

@frenck frenck added this to the 2023.10.2 milestone Oct 12, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this first, as is immediately addresses a bug that users are experiencing.

Thanks, @rklomp 👍

../Frenck

@frenck frenck merged commit b70e2f7 into home-assistant:dev Oct 12, 2023
23 checks passed
@rklomp rklomp deleted the fix-101643 branch October 12, 2023 11:15
frenck pushed a commit that referenced this pull request Oct 12, 2023
@frenck frenck mentioned this pull request Oct 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMA data not updating
4 participants