New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resolving Matrix room aliases #101928
Merged
edenhaus
merged 9 commits into
home-assistant:dev
from
PaarthShah:matrix-resolve-room-alias
Oct 23, 2023
Merged
Fix resolving Matrix room aliases #101928
edenhaus
merged 9 commits into
home-assistant:dev
from
PaarthShah:matrix-resolve-room-alias
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaarthShah
changed the title
Matrix resolve room alias
Bugfix: Resolve Matrix room aliases into room ids before calling client functions
Oct 13, 2023
edenhaus
requested changes
Oct 13, 2023
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
edenhaus
requested changes
Oct 16, 2023
MartinHjelmare
changed the title
Bugfix: Resolve Matrix room aliases into room ids before calling client functions
Fix resolving Matrix room aliases into room ids before calling client functions
Oct 16, 2023
edenhaus
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PaarthShah 👍
edenhaus
changed the title
Fix resolving Matrix room aliases into room ids before calling client functions
Fix resolving Matrix room aliases
Oct 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR fixes a regression in from before this integration's library was changed; users inadvertently lost the ability to configure the integration using Matrix room aliases.
The workaround of only using room ids works, but the proper fix as-implemented is to manually resolve room aliases into room ids, and cache them within
MatrixBot._listening_rooms
.In addition to this, I wanted to ensure that aliases were usable as input for manual service commands as well, and to ensure that the aliases are logged if available, rather than the ID, to ensure the user sees the input they expect rather than an obfuscated id.
To facilitate this change, I also included extra tests and debug logs.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: