Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix matter max setpoint #101929

Merged
merged 1 commit into from Oct 13, 2023
Merged

Fix matter max setpoint #101929

merged 1 commit into from Oct 13, 2023

Conversation

goloveychuk
Copy link
Contributor

No description provided.

@goloveychuk goloveychuk requested a review from a team as a code owner October 13, 2023 09:11
home-assistant[bot]
home-assistant bot previously requested changes Oct 13, 2023
View reviewed changes
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @goloveychuk

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 13, 2023 09:11
@home-assistant
Copy link

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@MartinHjelmare MartinHjelmare changed the title fix matter max setpoint Fix matter max setpoint Oct 13, 2023
@goloveychuk goloveychuk marked this pull request as ready for review October 13, 2023 10:44
marcelveldt
marcelveldt approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@marcelveldt marcelveldt added this to the 2023.10.4 milestone Oct 13, 2023
@marcelveldt marcelveldt merged commit 4e9ec82 into home-assistant:dev Oct 13, 2023
23 checks passed
@goloveychuk goloveychuk deleted the patch-1 branch October 13, 2023 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcelveldt marcelveldt marcelveldt approved these changes

@home-assistant home-assistant[bot] Awaiting requested review from home-assistant[bot]

Assignees
No one assigned
Labels
cherry-picked cla-signed Hacktoberfest integration: matter Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.10.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@goloveychuk @marcelveldt @frenck