Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Hydrawise initialize data immediately #101936

Merged
merged 4 commits into from Oct 30, 2023

Conversation

dknowles2
Copy link
Contributor

Proposed change

Fix the initialization of the Hydrawise integration so that entities have data available on initialization. As currently implemented, state attributes aren't updated until the first data coordinator refresh, which means entities have unavailable status for 2 minutes after startup.

This encompasses two changes:

  1. Update the base HydrawiseEntity class to set state attributes on initialization.
  2. Modify the startup procedure so that we don't immediately fetch data from the Hydrawise API when initializing the client, and instead explicitly wait for a data coordinator update before forwarding entity setups. (e.g. the way that most other integrations handle startup)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @ptcryan, mind taking a look at this pull request as it has been labeled with an integration (hydrawise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hydrawise can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hydrawise Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@dknowles2 dknowles2 marked this pull request as ready for review October 13, 2023 12:22
@dknowles2
Copy link
Contributor Author

Ping?

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 30, 2023 08:41
@edenhaus edenhaus added this to the 2023.11.0 milestone Oct 30, 2023
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dknowles2 👍

@edenhaus edenhaus merged commit f160fa4 into home-assistant:dev Oct 30, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
@dknowles2 dknowles2 deleted the hydrawise-fix-init branch November 17, 2023 01:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants