Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reach full init test coverage in Minecraft Server #102013

Merged
merged 3 commits into from Oct 17, 2023

Conversation

elmurato
Copy link
Contributor

@elmurato elmurato commented Oct 14, 2023

Proposed change

SSIA

Note:
Library mcstatus is now being patched instead of own code (was a late review finding in one of the older PRs).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: n.a.
  • This PR is related to issue: n.a.
  • Link to documentation pull request: n.a.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@elmurato elmurato changed the title Add full init test coverage in Minecraft Server Reach full init test coverage in Minecraft Server Oct 14, 2023
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 15, 2023 20:02
@elmurato elmurato marked this pull request as ready for review October 16, 2023 10:34
@home-assistant home-assistant bot marked this pull request as draft October 16, 2023 23:01
@allenporter allenporter marked this pull request as ready for review October 17, 2023 14:48
@allenporter allenporter merged commit 7cd3765 into home-assistant:dev Oct 17, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants