-
-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZHA cover tilt #102072
Add ZHA cover tilt #102072
Conversation
Hey there @dmulcahey, @Adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
029e14d
to
7230588
Compare
7230588
to
4896d09
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
This PR looks good, I think it would be good to get into the beta. So that CI is unblocked, could you add a few unit tests for |
There is a test at least for |
The changes to increase the coverage are hopefully done. While implementing them, perhaps I discovered a dead code in In case the dead |
One more warning: currently I am unable to test the code on a physically connected tilting cover device. If anyone here has an opportunity to test this branch if it still works good (compared to #93301), it would be nice. |
@tomasbedrich i’m testing your version since last week and it works fine. |
IMHO it works awesome - I tested all cover.xxx services https://www.home-assistant.io/integrations/cover#services with the nexentro (needs no quirk) and to me it looks good |
Specifically I'm interested if this code change didn't break anything, but I'm not sure how to test it. |
I'm also not sure - but maybe this should fixed here #99646 - since it has nothing to do with the tilt support. And the #99646 is anyway fixing states. If I understand this right it's for updating the cover state. This seems working (also with your last change). ![]() |
Proposed change
This PR adds support to control cover tilt as defined in Zigbee Cluster Library Specification (rev 8) 7.4.2.1.2.9.
There are multiple devices waiting for this support:
This PR is a duplicate of #93301, which is currently stale despite our numerous attempts to contact the author @josef109.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: