Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some entity categories to Reolink #102141

Merged
merged 2 commits into from Oct 17, 2023
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Oct 17, 2023

Breaking change

Proposed change

Recently got a Reolink PoE camera. Noticed a couple of entities missing the entity category.

Maybe person/motion could be considered diagnostic too but that can be for a future discussion.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (reolink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of reolink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign reolink Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@starkillerOG starkillerOG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

homeassistant/components/reolink/select.py Outdated Show resolved Hide resolved
homeassistant/components/reolink/siren.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 17, 2023 05:57
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@balloob balloob marked this pull request as ready for review October 17, 2023 17:15
@balloob
Copy link
Member Author

balloob commented Oct 17, 2023

Comments addressed.

@bdraco bdraco dismissed starkillerOG’s stale review October 17, 2023 17:28

Both commented places removed

Copy link
Contributor

@starkillerOG starkillerOG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@starkillerOG starkillerOG merged commit 4ae5757 into dev Oct 17, 2023
23 checks passed
@starkillerOG starkillerOG deleted the reolink-entity-category branch October 17, 2023 18:19
@starkillerOG
Copy link
Contributor

A bit off topic, but would like some input:
What would still be needed to get the Reolink integration to platinum level?

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
@balloob
Copy link
Member Author

balloob commented Oct 19, 2023

I don't know. I haven't checked the code very thorough. Generally it's the code owner opening a PR and marking things as checked. And they will be verifiedi n the PR.

@bdraco
Copy link
Member

bdraco commented Oct 19, 2023

@starkillerOG Example: #102069

@balloob
Copy link
Member Author

balloob commented Oct 19, 2023

Should is_recording switch have a config entity category?

@starkillerOG
Copy link
Contributor

Thanks for the info, will look into the quality scaled.

@balloob yes I think is_recording can be considered config. I did not add it yet since I think it is one of the main features of the camera (to record), and I did not want to push it to the bottom of the device page together with other less relevant settings. But indeed it is a setting not a pysicall control. So we can add the category

@balloob
Copy link
Member Author

balloob commented Oct 21, 2023

PR for record category #102439

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants