Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu in knx config flow #102168

Merged
merged 4 commits into from Oct 17, 2023
Merged

Fix menu in knx config flow #102168

merged 4 commits into from Oct 17, 2023

Conversation

emontnemery
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Julius2342, @farmio, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@emontnemery emontnemery mentioned this pull request Oct 17, 2023
20 tasks
Copy link
Contributor

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use more meaningful names for the menus? It would be better readable (translation and tests...)

homeassistant/components/knx/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/knx/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/knx/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/knx/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/knx/strings.json Outdated Show resolved Hide resolved
tests/components/knx/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/knx/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/knx/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/knx/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/knx/test_config_flow.py Outdated Show resolved Hide resolved
Copy link
Contributor

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - works fine 👍

Does this need new Lokalise work now since the menu step names changed?

@emontnemery
Copy link
Contributor Author

Tested locally - works fine 👍

Does this need new Lokalise work now since the menu step names changed?

Yes, we should ideally mend the existing translations. Do you have access to lokalise to do that?

@emontnemery emontnemery merged commit e6895b5 into dev Oct 17, 2023
23 checks passed
@emontnemery emontnemery deleted the knx_fix_menu branch October 17, 2023 20:25
@farmio
Copy link
Contributor

farmio commented Oct 18, 2023

I think I have the same access level as every user. Don't have much experience with Lokalise.
Do the keys have to be manually added again in all languages, or can it be copied over from the previous translation?
What about the now stale ::step::secure_key_source:: keys - they are still visible in Lokalise. I guess they should be deleted somehow.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants