Handle timeouts on AEMET init #102289
Merged
Handle timeouts on AEMET init #102289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
home-assistant
bot
added
bugfix
cla-signed
Hacktoberfest
has-tests
integration: aemet
small-pr
elupus
approved these changes
Oct 19, 2023
| @@ -37,6 +39,8 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: | |||
| except TownNotFound as err: | |||
| _LOGGER.error(err) | |||
| return False | |||
| except asyncio.TimeoutError as err: | |||
There was a problem hiding this comment.
You should probably catch this internally in the library to avoid leaking details that its using aiohttp behind the scenes. But good for now.
There was a problem hiding this comment.
Ok, I'll do that, thanks!
|
@elupus can we add this to the 2023.10.4 milestone? |
|
Yes i think so. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Handle timeouts on AEMET init.
As reported by users, the API sometimes times out while loading the integration for the first time and after manually reloading it works fine:
#101812
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: