-
-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serial_number to device registry entries #102334
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Users have trouble identifying which device is which when integration don't provide a name (because they do not have a useful one in the data source), and only a mac address or serial number. This will be very helpful in figuring out which device is which if we also include the mac in the UI |
entry = registry.async_get_or_create( | ||
config_entry_id=mock_config_entry.entry_id, | ||
connections={("Zigbee", "01.23.45.67.89")}, | ||
identifiers={("serial", "12:34:56:AB:CD:EF")}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if the serial didn't look like a mac address in the test as it initially confused me
The code LGTM, but I don't follow why the first version was reverted in #79139. I am missing some context |
Sorry about that, I added some context to the PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for uptime
needs it snapshot regenerated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a frontend PR before merge or are we good to merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think we can merge this without having a frontend part at this point.
Will make a task for the frontend team to pick up.
../Frenck
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Proposed change
Add serial_number to device registry entries
The serial number can be displayed in the device card in frontend
The "identifiers" set which is part of device registry entries can't be used for this purpose because:
Developer documentation: home-assistant/developers.home-assistant#1477
Note: This is a rebased version of #77713
#77713 was reverted by #79139 because there was an idea that we would like to add additional attributes and collect them in some sub data structure with device meta data.
However, the specific case with serial numbers was brought up again in home-assistant/architecture#987, and there's no consensus on any additional attributes.
After a discussion with @edenhaus, @MartinHjelmare and @frenck, we concluded serial number is wanted and we should add it without any bigger architecture change to the device registry.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: