Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pydiscovergy to 2.0.5 #102354

Merged
merged 1 commit into from Oct 20, 2023
Merged

Bump pydiscovergy to 2.0.5 #102354

merged 1 commit into from Oct 20, 2023

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Oct 19, 2023

Proposed change

Bump pydiscovergy to 2.0.5 to resolve a issue when the API is not returning any JSON. Ideally, this can be included in the next bugfix release.

https://github.com/jpbede/pydiscovergy/releases/tag/2.0.5
jpbede/pydiscovergy@2.0.4...2.0.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck merged commit 6f83374 into home-assistant:dev Oct 20, 2023
53 checks passed
@jpbede jpbede deleted the discovergy-bump branch October 20, 2023 12:55
@frenck
Copy link
Member

frenck commented Oct 20, 2023

This PR cannot be cleanly merged into the current patch release. Therefore removing it from the milestone.

@frenck frenck removed this from the 2023.10.4 milestone Oct 20, 2023
@jpbede
Copy link
Member Author

jpbede commented Oct 20, 2023

Ok, no problem. Thanks 🙂

@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discovergy integration not connection after server crash at Discovergy
3 participants