Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid more device_class lookups for number entities when writing state #102381

Merged
merged 2 commits into from Oct 22, 2023
Merged

Avoid more device_class lookups for number entities when writing state #102381

merged 2 commits into from Oct 22, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 20, 2023 •
edited

Proposed change

I missed some more in min/max value

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration (number) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of number can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign number Removes the current integration label and assignees on the pull request, add the integration domain after the command.

bdraco
bdraco commented Oct 20, 2023
View reviewed changes
homeassistant/components/number/__init__.py
Comment on lines 264 to +269
@final
def min_value(self) -> float:
"""Return the minimum value."""
return self._convert_to_state_value(self.native_min_value, floor_decimal)
return self._convert_to_state_value(
self.native_min_value, floor_decimal, self.device_class
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need this but I left it for backwards compat

bdraco
bdraco commented Oct 20, 2023
View reviewed changes
homeassistant/components/number/__init__.py
Comment on lines 284 to +289
@final
def max_value(self) -> float:
"""Return the maximum value."""
return self._convert_to_state_value(self.native_max_value, ceil_decimal)
return self._convert_to_state_value(
self.native_max_value, ceil_decimal, self.device_class
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need this but I left it for backwards compat

@bdraco bdraco marked this pull request as ready for review October 20, 2023 10:50
@bdraco bdraco requested a review from a team as a code owner October 20, 2023 10:50
elupus
elupus reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm fine with this. it feels lika a bit of a slippery slope to optimize on this small scale though. I think i want some other eyes on it.

frenck
frenck approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

I agree with Joakim a bit, but then again, these are internal and are allowed to be a bit more complex.

../Frenck

@frenck frenck merged commit b980ed3 into dev Oct 22, 2023
53 checks passed
@frenck frenck deleted the number_device_class branch October 22, 2023 21:55
@bdraco
Copy link
Member Author

bdraco commented Oct 22, 2023

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elupus elupus elupus left review comments

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed core Hacktoberfest integration: number Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bdraco @frenck @elupus