Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add early return check to passive Bluetooth entities listener #102435

Merged
merged 1 commit into from Oct 21, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 21, 2023

Proposed change

Most of the time we can avoid iterating in python code

This is covered by existing tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Most of the time we can avoid iterating in python code
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I wonder how something like:

keys = data.bla.keys() - created
for key in keys:
  new = data.bla[key]
  ...

Probably slower for the creation, i wonder if there is some neat python trick to get values and filter keys at the same time.

@bdraco
Copy link
Member Author

bdraco commented Oct 21, 2023

I wonder how something like:

keys = data.bla.keys() - created
for key in keys:
  new = data.bla[key]
  ...

That should work fine, but likely a bit slower than the optimized path of issuperset has a c implementation https://github.com/python/cpython/blob/5e7727b05232b43589d177c15263d7f4f8c584a0/Objects/setobject.c#L1760

Would have to try and compare, but TBH it almost never ends the rest of the body of the function after this change so something to think about for the future.

@bdraco
Copy link
Member Author

bdraco commented Oct 21, 2023

Thanks

@bdraco bdraco merged commit 89f9d64 into dev Oct 21, 2023
53 checks passed
@bdraco bdraco deleted the passive_bluetooth_entity_listener_early_return branch October 21, 2023 20:06
iotmaestro pushed a commit to iotmaestro/home-assistant-core that referenced this pull request Oct 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants