Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modernized fitbit battery level sensor #102500

Merged
merged 9 commits into from Nov 2, 2023
Merged

Add modernized fitbit battery level sensor #102500

merged 9 commits into from Nov 2, 2023

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Oct 21, 2023 •
edited

Proposed change

Add modernized fitbit battery level sensor that uses the battery device class (The existing battery sensor uses a string label state)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@allenporter allenporter marked this pull request as draft October 21, 2023 22:39
@allenporter allenporter marked this pull request as ready for review October 21, 2023 22:46
joostlek
joostlek previously requested changes Oct 21, 2023
View reviewed changes
homeassistant/components/fitbit/sensor.py Show resolved Hide resolved
homeassistant/components/fitbit/strings.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 21, 2023 22:53
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@allenporter allenporter marked this pull request as ready for review October 22, 2023 22:16
@home-assistant home-assistant bot marked this pull request as draft October 23, 2023 20:32
This was referenced Oct 28, 2023
Merged
Closed
janvanicek
janvanicek reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@janvanicek janvanicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I wanted to make this change of battery sensor for a long time, but you were faster @allenporter 👍

homeassistant/components/fitbit/sensor.py Outdated Show resolved Hide resolved
@allenporter @janvanicek
Update homeassistant/components/fitbit/sensor.py
43c3b07 
Co-authored-by: Jan Vaníček <janvanicek@post.cz>
@allenporter allenporter marked this pull request as ready for review November 2, 2023 04:54
MartinHjelmare
MartinHjelmare approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

Codecov comment doesn't make sense.

@MartinHjelmare MartinHjelmare merged commit fe482af into home-assistant:dev Nov 2, 2023
22 of 23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janvanicek janvanicek janvanicek left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@joostlek joostlek Awaiting requested review from joostlek

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality Hacktoberfest has-tests integration: fitbit new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@allenporter @MartinHjelmare @joostlek @janvanicek