New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new API for Vasttrafik #102570
Use new API for Vasttrafik #102570
Conversation
Please add a link to the new release of the library to the pull request. |
Link to library release added |
This comment was marked as outdated.
This comment was marked as outdated.
This is only a link to pypi, but we require at least one (or multiple) of the following:
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant. Thanks already! 👍 |
Better a hard breaking change from one release of HA to another, than a API breaking change on the 30 of november leaving users to wait for a new HA. I think hard breaking directly is fine here. Its so short time to the API shutting down (from next ha release), that we wont gain anything by that. |
Aha, that makes sense! I should release the version on Github too, did only release it on pypi. Since I took over from the last developer (who won't be maintinaing it anymore), I think that the diff between the repos will be the best representation of the changes. PR description is now updated, let me know if it is missing something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Miicroo
We will include it in the next beta as the API is shutting down on 30.11
Breaking change
Västtrafik has upgraded all infrastructure for handling external API calls, including handling user accounts for 3rd party applications. This means that users of the older infrastructure now need to migrate to use the new environment. Create a new account at https://developer.vasttrafik.se, then create a new application and subscribe to the Planera Resa v4 API. Then replace your old client identifier and secret in your HomeAssistant configuration.
See this official post from Västtrafik.
Change since last version: From v0.1.14 to v0.2.1
Proposed change
This change uses the new API and new responses. The old API has already been closed for new applications, so with this PR new users are able to start using the Västtrafik sensors again.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: