Fix invalid sources in media player sources list #102646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The Frontier Silicon media player integration lists all sources that the device provides. To do this the integration calls the device API and generates the list based on the
label
field of the API response.Some devices have been found to return sources where the
label
isnull
/None
. This leads to a blank entry in the sources list in the UI. Worse still, this behavior breaks other integrations that expect null-safe sources from media players.With this PR the integration uses the
id
field of the API response as a fallback when thelabel
is null or empty. Theid
field is always populated.This PR addresses issue #100274.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: