Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugwise to v0.33.2 #102671

Merged
merged 3 commits into from Oct 24, 2023
Merged

Bump plugwise to v0.33.2 #102671

merged 3 commits into from Oct 24, 2023

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Oct 24, 2023

Proposed change

Bump plugwise to v0.33.2

https://github.com/plugwise/python-plugwise/releases/tag/v0.33.2
plugwise/python-plugwise@v0.33.1...v0.33.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

The last_used schedule name is no longer provided to the Plugwise integration, the backend now remembers the last_used schedule name. As as result of this change the climate.turn_on service is now properly supported.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of plugwise can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign plugwise Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bouwew bouwew marked this pull request as ready for review October 24, 2023 18:15
@bouwew bouwew requested a review from frenck as a code owner October 24, 2023 18:15
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bouwew 👍

Test failure is not related, so going to continue on the merge.

../Frenck

@frenck frenck merged commit a5461a9 into home-assistant:dev Oct 24, 2023
48 of 49 checks passed
@bouwew bouwew deleted the pw-0_33_2 branch October 25, 2023 05:56
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugwise does not support climate.turn_on/turn_off
2 participants