New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional sensors to ecoforest integration #102734
Add additional sensors to ecoforest integration #102734
Conversation
So wait, not every ecoforest supports these entities? |
Not sure why you mentioned that, I can only test with my device, as mentioned in docs is the only tested device at this moment, there is no public documentation about the different devices, firmwares and APIs. |
Oh just out of curiosity, maybe not every ecoforest model supports every sensor. If that was the case, we could not create the entity at all. But if that isn't the case we can do this PR |
When we get feedback from other models we can make the entity creation conditional |
Also, please include release notes or a diff of the dependency bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include the release notes and diff, I have on remark, other than that it's good
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I am not at the laptop, release changes are here. https://github.com/pjanuario/pyecoforest/releases/tag/v0.4.0 Short story added functionality to support this additional sensors and dependency updates. |
Put them in the description! |
I am on mobile, so it's hard to make changes and I will review it later if any other changes needed, but I see the changes in the description I guess you added. |
Please don't merge dev or add other things to the PR after it was approved (if not requested by the reviewer). This makes the approval stale, and we need to review it again. |
Sorry, I was trying to keep the branch in sync to be ready to be merged, wasn't aware of that part of the process. |
Should I revert last commit? Or leave as it is now? |
Leave it, I'm already reviewing it |
@pjanuario You don't need to merge dev into your PR each day/week. If a reviewer thinks the branch it outdated, it will rebase dev onto it. |
There already are docs linked :) |
The app didn't showed it... On desktop yes |
Nice 😃 |
Proposed change
Some members of the community were using proxy that exposed additional sensors and they requested to include this sensors in the integration.
Add the following sensors to the ecoforest integration:
Minor dependency upgrade:
pjanuario/pyecoforest@v0.3.0...v0.4.0
This dependency upgrade includes features to support new sensors and upgrades of internal dependencies.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: