Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESPHome Text entities #102742

Merged
merged 3 commits into from Oct 25, 2023
Merged

ESPHome Text entities #102742

merged 3 commits into from Oct 25, 2023

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Oct 24, 2023

Breaking change

Proposed change

Implements text entities for ESPHome devices.

Related PRs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @OttoWinter, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@jesserockz jesserockz marked this pull request as draft October 24, 2023 23:04
@jesserockz jesserockz closed this Oct 25, 2023
@jesserockz jesserockz reopened this Oct 25, 2023
@jesserockz jesserockz marked this pull request as ready for review October 25, 2023 02:55
@bdraco
Copy link
Member

bdraco commented Oct 25, 2023

wheels are cooking
https://github.com/home-assistant/core/actions/runs/6635326533

will test to make sure no obvious regressions when they finish baking for x86_64

@bdraco
Copy link
Member

bdraco commented Oct 25, 2023

@bdraco
Copy link
Member

bdraco commented Oct 25, 2023

Both primary production systems restarted and esphome devices responding as expected. I did only basic sanity testing and did not specifically test the text entity as I haven't flashed anything with it yet.

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Oct 25, 2023
@bdraco
Copy link
Member

bdraco commented Oct 25, 2023

Ran through this one again and still looks good. If there are any more changes it's likely to be in the esphome side

@bdraco bdraco merged commit ad692f3 into dev Oct 25, 2023
69 of 70 checks passed
@bdraco bdraco deleted the jesserockz-2023-367 branch October 25, 2023 04:15
@bdraco bdraco removed the smash Indicator this PR is close to finish for merging or closing label Oct 25, 2023
@jesserockz
Copy link
Member Author

Thanks @bdraco ❤️

@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants