Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation of device automations #102766

Merged
merged 3 commits into from Oct 26, 2023

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Oct 25, 2023

Proposed change

Improve validation of device automations:

  • Fail validation if a device automation references a device which does not exist
  • Fail validation if a device automation references an entity registry id which does not exist

This fixes the error seen in https://gist.github.com/woutf/1e51a566817aaf9f4865b72189ac1877

Needs #102692 + #102785 + #102824 for tests to pass

Startup log with this PR

2023-10-25 11:03:53.537 ERROR (MainThread) [homeassistant.components.automation] Automation with alias 'Test automation' failed to setup conditions and has been disabled: Unknown entity '7d18a157b7c00adbf2982ea7de0d0362'

UI feedback when attempting to save an automation with this PR

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (device_automation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of device_automation can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign device_automation Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco
Copy link
Member

bdraco commented Oct 25, 2023

Looks like the script test failure is legitimate

@frenck frenck added this to the 2023.11.0 milestone Oct 25, 2023
@balloob balloob force-pushed the improve_device_automation_validation_2 branch from 052ce24 to 6e77af5 Compare October 26, 2023 03:21
@emontnemery emontnemery merged commit 087df10 into dev Oct 26, 2023
53 checks passed
@emontnemery emontnemery deleted the improve_device_automation_validation_2 branch October 26, 2023 07:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants