Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring Withings activity sensor creation in line with the others #102771

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Bring Withings activity sensor creation in line with the others #102771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 16 additions & 14 deletions homeassistant/components/withings/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,26 +705,28 @@ def _async_goals_listener() -> None:

activity_coordinator = withings_data.activity_coordinator

activity_callback: Callable[[], None] | None = None

activity_entities_setup_before = ent_reg.async_get_entity_id(
Platform.SENSOR, DOMAIN, f"withings_{entry.unique_id}_activity_steps_today"
)

def _async_add_activity_entities() -> None:
"""Add activity entities."""
if activity_coordinator.data is not None or activity_entities_setup_before:
async_add_entities(
WithingsActivitySensor(activity_coordinator, attribute)
for attribute in ACTIVITY_SENSORS
)
if activity_callback:
activity_callback()

if activity_coordinator.data is not None or activity_entities_setup_before:
_async_add_activity_entities()
entities.extend(
WithingsActivitySensor(activity_coordinator, attribute)
for attribute in ACTIVITY_SENSORS
)
else:
activity_callback = activity_coordinator.async_add_listener(
remove_activity_listener: Callable[[], None]

def _async_add_activity_entities() -> None:
"""Add activity entities."""
if activity_coordinator.data is not None:
async_add_entities(
WithingsActivitySensor(activity_coordinator, attribute)
for attribute in ACTIVITY_SENSORS
)
remove_activity_listener()

remove_activity_listener = activity_coordinator.async_add_listener(
_async_add_activity_entities
)

Expand Down