Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESPHome: Add suggested_area from device info #102834

Merged
merged 1 commit into from Oct 26, 2023
Merged

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Oct 26, 2023

Breaking change

Proposed change

Adds the suggested area to ESPHome devices if specified in yaml configuration.

image

esphome/aioesphomeapi@v18.1.0...v18.2.0

Related PRs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @OttoWinter, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@jesserockz
Copy link
Member Author

Unrelated test failures?

@edenhaus
Copy link
Contributor

Unrelated test failures?

Yes they are unrelated

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jesserockz 👍

@edenhaus edenhaus merged commit 4838b2d into dev Oct 26, 2023
59 of 64 checks passed
@edenhaus edenhaus deleted the jesserockz-2023-374 branch October 26, 2023 07:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
@bdraco bdraco added this to the 2023.11.2 milestone Nov 8, 2023
@bdraco
Copy link
Member

bdraco commented Nov 8, 2023

tagging this so #103552 can cherry-pick cleanly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants