Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tedee integration #102846

Merged
merged 88 commits into from Dec 29, 2023
Merged

Add tedee integration #102846

merged 88 commits into from Dec 29, 2023

Conversation

zweckj
Copy link
Contributor

@zweckj zweckj commented Oct 26, 2023

Breaking change

Proposed change

Move the custom component for tedee locks to core.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@DCSBL DCSBL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not finished everything, but here you have a tiny bit of feedback :)

homeassistant/components/tedee/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/tedee/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/tedee/config_flow.py Outdated Show resolved Hide resolved
zweckj and others added 9 commits December 28, 2023 22:38
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@zweckj zweckj marked this pull request as ready for review December 29, 2023 08:18
homeassistant/components/tedee/const.py Outdated Show resolved Hide resolved
homeassistant/components/tedee/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/tedee/strings.json Outdated Show resolved Hide resolved
tests/components/tedee/test_config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 29, 2023 09:20
zweckj and others added 4 commits December 29, 2023 10:28
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@zweckj zweckj marked this pull request as ready for review December 29, 2023 09:37
@joostlek joostlek merged commit 02b863e into home-assistant:dev Dec 29, 2023
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants