Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier to 3.0.3 #102929

Merged
merged 1 commit into from Oct 28, 2023
Merged

Update prettier to 3.0.3 #102929

merged 1 commit into from Oct 28, 2023

Conversation

scop
Copy link
Member

@scop scop commented Oct 27, 2023

Proposed change

Update to currently maintained branch, main 3.0 news entry at https://prettier.io/blog/2023/07/05/3.0.0.html

No formatting changes caused.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco merged commit 7d59880 into dev Oct 28, 2023
53 checks passed
@bdraco bdraco deleted the scop-prettier-update branch October 28, 2023 13:56
@frenck
Copy link
Member

frenck commented Oct 29, 2023

I wonder if we should replace it with dprint, to completely eliminate the need of node in our environments.

@scop
Copy link
Member Author

scop commented Oct 29, 2023

There at least used to be some problems with dprint and pre-commit; I don't remember the exact details and the reasoning given in the archived https://github.com/adamchainz/pre-commit-dprint doesn't sound unsolvable though.

Then again, that particular repo happened to use npm to install dprint, so the node dep would have been there anyway with it.

Not sure if a dependency on rust would be more welcome, JFYI adamchainz/pre-commit-dprint#2

I guess what would work best for HA would be if someone created a Python download wrapper like there is for shellcheck at https://github.com/shellcheck-py/shellcheck-py, or dprint was available in PyPI like ruff.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants