-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanups in HomeWizard Energy sensors #102936
Conversation
Hey there @DCSBL, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This maybe needs to be flagged as breaking, as it removes the l1 sensor for sockets/single-phase meters. (Which may cause issues with automations and stuff) |
You are right. Going to combine some more breaking changes into this PR in that case, to make a single breaking change PR. |
The current state is not good for the |
Instead of hiding the duplicate entities, can’t we just disable them by default? This makes it non-breaking. |
Let me fix that in the python library, as we plan to add I will update the library to always have that datapoint when total_power_*_t1_kwh is set. |
total_power_*_kwh
when only total_power_*_t1_kwh
is set
homewizard/python-homewizard-energy#278
Closing this one. There is not much in it, but it is intertwined. |
Proposed change
When a HomeWizard Energy device only measures a single phase (e.g., a plug or single-phase kWh meter), it will create a duplicate power sensor.
Normally the integration creates a sensor for each phase + a total. However, when there is just a single phase, the total & the phase sensors, will have the same value (and thus, duplicate data is shown and recorded).
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: