Show proper name on Airzone Cloud errors #102998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
home-assistant
bot
added
bugfix
cla-signed
Hacktoberfest
integration: airzone_cloud
small-pr
Noltari
changed the title
Noltari
changed the title
| @@ -386,4 +387,6 @@ async def async_set_hvac_mode(self, hvac_mode: HVACMode) -> None: | |||
| await self._async_update_params(params) | |||
|
|
|||
| if slave_raise: | |||
| raise HomeAssistantError(f"Mode can't be changed on slave zone {self.name}") | |||
| raise HomeAssistantError( | |||
| f"Mode can't be changed on slave zone {self.get_airzone_value(AZD_NAME)}" | |||
There was a problem hiding this comment.
Another option which I think is more used is self.entity_id given that a user can rename their devices etc.
There was a problem hiding this comment.
Another option which I think is more used is
self.entity_idgiven that a user can rename their devices etc.
Done in 1cfc888
Thanks!
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Show proper entity name on Airzone Cloud errors.
After entity name code changes, if there's a HomeAssistantError raised, None will be shown for its name.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: