Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in fitbit credential import for expired tokens #103024

Merged
merged 3 commits into from Oct 29, 2023
Merged

Fix bug in fitbit credential import for expired tokens #103024

merged 3 commits into from Oct 29, 2023

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Oct 29, 2023 •
edited

Proposed change

Fix bug in fitbit credential import for expired tokens. The pervious fix in #102833 was still importing the expired token, rather than the updated token.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@allenporter allenporter added this to the 2023.11.0 milestone Oct 29, 2023
@allenporter allenporter marked this pull request as draft October 29, 2023 18:11
@allenporter allenporter marked this pull request as ready for review October 29, 2023 18:12
@allenporter @MartinHjelmare
Update homeassistant/components/fitbit/sensor.py
c2057ca 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@allenporter allenporter merged commit d75f1b2 into home-assistant:dev Oct 29, 2023
23 checks passed
frenck pushed a commit that referenced this pull request Oct 30, 2023
@allenporter @MartinHjelmare @frenck
Fix bug in fitbit credential import for expired tokens (#103024)
f5b3661 
* Fix bug in fitbit credential import on token refresh

* Use stable test ids

* Update homeassistant/components/fitbit/sensor.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

---------

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed Hacktoberfest has-tests integration: fitbit Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.11.0
Development

Successfully merging this pull request may close these issues.

Error while setting up fitbit platform for sensor
3 participants
@allenporter @MartinHjelmare @frenck